Attention is currently required from: osmith, neels, pespin.

View Change

2 comments:

• File src/osmo-bsc-nat/bsc_nat_fsm.c:

  • Patch Set #8, Line 129: ss7_inst_free(bsc_nat->cn);

    This looks really strange. […]

    Ack, agree with Pau.

• File src/osmo-bsc-nat/main.c:

  • Patch Set #8, Line 148: if (g_bsc_nat->shutdown)

    Can you explain why are you changing this?
    What's wrong with osmo_select_shutdown_requested()?

To view, visit change 26662. To unsubscribe, or for help writing mail filters, visit settings.