Attention is currently required from: osmith, Hoernchen, neels, pespin, fixeria, daniel.

Patch set 7:Code-Review +1

View Change

4 comments:

• Patchset:

  • Patch Set #7:

    looks good, just some cosmetic stuff...

• File src/core/osmo_io.c:

  • Patch Set #7, Line 5: 2022

    probably also 2023 now. Not super important.

  • Patch Set #7, Line 349: iofd(%s)

    I see multiple log lines manually encoding this prefix. Guess it's time for a LOGPIO(iofd, level, fmt , ...) macro that encapsulates that?

  • Patch Set #7, Line 432: using backend %s

    as the backend is global, I'm not sure we need to log this every time?

To view, visit change 30934. To unsubscribe, or for help writing mail filters, visit settings.