Attention is currently required from: laforge.

Patch set 1:Code-Review +1

View Change

1 comment:

• File src/input/ipaccess.c:

  • Patch Set #1, Line 535: }

    I think with this change you are leaving write enabled even if there's no more stuff in the queue to send for this TS. So that means poll will trigger again and end up in the path of line 496 (e1inp_tx_ts() returning NULL).

    So ideally, in this line there would be an:
    else {
        if (list_for_this_ts_is_empty())
            osmo_fd_write_disable(bfd);
    }

    This can of course be seen as an extra optimization, done in a different patch.

To view, visit change 28063. To unsubscribe, or for help writing mail filters, visit settings.