Attention is currently required from: jolly, laforge.

Patch set 7:Code-Review +1

View Change

3 comments:

• File src/ipa/libipa/euicc.c:

  • Patch Set #7, Line 535: /* Capabilities according to 3GPP TS 102.221, section 11.1.19.2.4 and GSMA SGP.32, section 3.8.2 */

    Maybe we should also add GSMA SGP.22, section 3.4.2. In ipad.h you refer to this spec.

• File src/ipa/main.c:

  • Patch Set #7, Line 72: printf(" -D 0xXX ..................... set SGP.22 device capabilities other than the 3 that are required by this IPAd\n");

    maybe point directly to the table like: set optional device capabilities (SGP.22, table 7, b8-b4) ?

  • Patch Set #7, Line 288: printf(" device_capabilities = %u\n", cfg.device_capabilities);

    Maybe use %02x because it is a bitmask?

To view, visit change 43060. To unsubscribe, or for help writing mail filters, visit settings.