pespin submitted this change.

View Change



4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified
layer23: mobile: Mark several functions static

Change-Id: Ifdeef9373b903d14fb2f4ec4caa1bf8c42b45aa1
---
M src/host/layer23/src/mobile/app_mobile.c
M src/host/layer23/src/mobile/main.c
2 files changed, 17 insertions(+), 10 deletions(-)

diff --git a/src/host/layer23/src/mobile/app_mobile.c b/src/host/layer23/src/mobile/app_mobile.c
index 1fdb275..54f0e6d 100644
--- a/src/host/layer23/src/mobile/app_mobile.c
+++ b/src/host/layer23/src/mobile/app_mobile.c
@@ -92,7 +92,7 @@
}

/* SIM becomes ATTACHED/DETACHED, or answers a request */
-int mobile_l23_subscr_signal_cb(unsigned int subsys, unsigned int signal,
+static int mobile_l23_subscr_signal_cb(unsigned int subsys, unsigned int signal,
void *handler_data, void *signal_data)
{
struct msgb *nmsg;
@@ -135,8 +135,8 @@
}

/* run ms instance, if layer1 is available */
-int mobile_signal_cb(unsigned int subsys, unsigned int signal,
- void *handler_data, void *signal_data)
+static int mobile_signal_cb(unsigned int subsys, unsigned int signal,
+ void *handler_data, void *signal_data)
{
struct osmocom_ms *ms;
struct gsm_settings *set;
@@ -412,8 +412,8 @@
}

/* handle global shutdown */
-int global_signal_cb(unsigned int subsys, unsigned int signal,
- void *handler_data, void *signal_data)
+static int global_signal_cb(unsigned int subsys, unsigned int signal,
+ void *handler_data, void *signal_data)
{
struct osmocom_ms *ms, *ms2;

@@ -437,7 +437,7 @@
}

/* global work handler */
-int _mobile_app_work(void)
+static int _mobile_app_work(void)
{
struct osmocom_ms *ms, *ms2;
int work = 0;
@@ -472,7 +472,7 @@
}

/* global exit */
-int _mobile_app_exit(void)
+static int _mobile_app_exit(void)
{
osmo_signal_unregister_handler(SS_L23_SUBSCR, &mobile_l23_subscr_signal_cb, NULL);
osmo_signal_unregister_handler(SS_L1CTL, &gsm322_l1_signal, NULL);
@@ -487,7 +487,7 @@
}


-int _mobile_app_start(void)
+static int _mobile_app_start(void)
{
int rc;

diff --git a/src/host/layer23/src/mobile/main.c b/src/host/layer23/src/mobile/main.c
index eca082a..11ffd95 100644
--- a/src/host/layer23/src/mobile/main.c
+++ b/src/host/layer23/src/mobile/main.c
@@ -64,8 +64,6 @@
int (*l23_app_exit)(void) = NULL;

int mobile_delete(struct osmocom_ms *ms, int force);
-int mobile_signal_cb(unsigned int subsys, unsigned int signal,
- void *handler_data, void *signal_data);
int mobile_work(struct osmocom_ms *ms);
int mobile_exit(struct osmocom_ms *ms, int force);


To view, visit change 32429. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ifdeef9373b903d14fb2f4ec4caa1bf8c42b45aa1
Gerrit-Change-Number: 32429
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-MessageType: merged