pespin submitted this change.

View Change

Approvals: laforge: Looks good to me, approved pespin: Verified
server: Correct error check calling osmo_pcap_conn_process_data()

The function is not expected to return >0, so clarify it when calling
it.

Change-Id: I8338b886db7bb7996229d78fe19025ebe5d0c5f8
---
M src/osmo_server_network.c
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/osmo_server_network.c b/src/osmo_server_network.c
index c93ce6d..5b31958 100644
--- a/src/osmo_server_network.c
+++ b/src/osmo_server_network.c
@@ -252,7 +252,7 @@
if ((rc = validate_link_data(conn, data)) < 0)
return rc;

- if ((rc = osmo_pcap_conn_process_data(conn, &data->data[0], data->len)))
+ if ((rc = osmo_pcap_conn_process_data(conn, &data->data[0], data->len)) < 0)
return rc;
return 1;
}

To view, visit change 39366. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: I8338b886db7bb7996229d78fe19025ebe5d0c5f8
Gerrit-Change-Number: 39366
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>