Attention is currently required from: fixeria, laforge, osmith.
1 comment:
File pySim/transport/__init__.py:
Patch Set #4, Line 318: except Exception as e
I am wondering if we really need to catch exceptions here. […]
I also think that not catching the exception at all would be the better solution. The caller still has the option to handle the exception and print it nicely if he wants to.
I submitted the new approach here: I4c4807576fe63cf71a7d33b243a3f8fea0b7ff23
To view, visit change 34687. To unsubscribe, or for help writing mail filters, visit settings.