fixeria has uploaded this change for review.

View Change

tests/gsm0408: remove outdated comment for bcap_csd_2400_v22bis

The problem has been fixed in aec32dbf ("gsm48_encode_bearer_cap():
properly set 'Structure' in octet 4") and the testcase is now passing.

Change-Id: I4732cc08a485695e8b4dda47ed602046352c5759
---
M tests/gsm0408/gsm0408_test.c
1 file changed, 1 insertion(+), 3 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/14/38914/1

diff --git a/tests/gsm0408/gsm0408_test.c b/tests/gsm0408/gsm0408_test.c
index 7456ed8..5566b7c 100644
--- a/tests/gsm0408/gsm0408_test.c
+++ b/tests/gsm0408/gsm0408_test.c
@@ -131,9 +131,7 @@
 static const struct bcap_test bcap_tests[] = {
 	{ csd_9600_v110_lv, &bcap_csd_9600_v110, "CSD 9600/V.110/transparent" },
 	{ csd_4800_rlp_lv, &bcap_csd_4800_rlp, "CSD 4800/RLP/non-transparent" },
-	{ /* XXX: this testcase is expected to fail because octet 4 is not represented in
-	   * 'struct gsm_mncc_bearer_cap' and the encoder unconditionally hard-codes it to 0x88. */
-	  csd_2400_v22bis_lv, &bcap_csd_2400_v22bis, "CSD 2400/V.22bis/transparent" },
+	{ csd_2400_v22bis_lv, &bcap_csd_2400_v22bis, "CSD 2400/V.22bis/transparent" },
 	{ speech_all_lv, &bcap_speech_all, "Speech, all codecs" },
 	{ speech_no3a_lv, &bcap_speech_no3a, "Speech, without octet 3a" },
 };

To view, visit change 38914. To unsubscribe, or for help writing mail filters, visit settings.