Attention is currently required from: laforge, neels.

View Change

1 comment:

• File include/osmocom/core/jhash.h:

  • Patch Set #1, Line 100: c += osmo_load32le(k + 8);

    (actually this also assumes a little-endian CPU. […]

    Why don't you simply copy the following code in this same file instead of changing it?

        struct __una_u32 { u32 x; } __packed;

        static inline u32 __get_unaligned_cpu32(const void *p)
        {
        	const struct __una_u32 *ptr = (const struct __una_u32 *)p;
        	return ptr->x;
        }
        
    Better change the prefix to osmo_.

To view, visit change 36913. To unsubscribe, or for help writing mail filters, visit settings.