Attention is currently required from: Hoernchen.

Patch set 2:Code-Review -1

View Change

4 comments:

• File ccid_common/ccid_slot_fsm.c:

  • Patch Set #2, Line 229: resp = ccid_gen_data_block(cs, ss->seq, CCID_CMD_STATUS_TIME_EXT, 1, NULL, 0);

    can we be sure that we can allocate sufficient waitign time extension messages? what a about a card that DoSs us with an infinite sequence of rapid 0x60 messages?

    IMHO it would be safer to decrement the wtime_ext counter only individually for each message we sent to the host, and in case of allocation failures (resp == NULL?) simply keep the count at non-zero until the next turn.

• File ccid_common/iso7816_fsm.h:

  • Patch Set #2, Line 25: ISO7816_E_RX_SINGLE, /*!< single-byte data received on UART */

    this cosmetic re-formatting or code does not belong to the patch. I guess you're not using 'git add -p' before committing?

• File ccid_common/iso7816_fsm.c:

  • Patch Set #2, Line 227: { ISO7816_E_TX_ERR_IND, "TX_ERR_IND" },

    same as above

  • Patch Set #2, Line 555: S(ISO7816_E_POWER_UP_IND),

    and more cosmetic changes

To view, visit change 42306. To unsubscribe, or for help writing mail filters, visit settings.