fixeria has uploaded this change for review.

View Change

msc: do not execute TC_gsup_mt_sms_lu_delay against -latest

This patch fixes regressions in ttcn3-msc-test-latest caused by a
recently merged patch adding MSC_Tests.TC_gsup_mt_sms_lu_delay.

I was expecting it to fail early at this line:

f_vty_config(MSCVTY, "msc", "timer geran X36 2500"); /* 2.5s */

since timer X36 is not available in the -latest yet. But this
function executes just fine and the error response is simply ignored.

The -latest version of osmo-msc closes the A-connection early and
then tries to deliver a MT SMS while executing subsequent testcases.

Change-Id: I0b07076a054e30c5a9023de18f2c70f15c97f8cc
Fixes: 8d0d7af2 "msc: add TC_gsup_mt_sms_lu_delay for X36 (LU delay) timer"
Related: SYS#6913
---
M msc/MSC_Tests.ttcn
1 file changed, 29 insertions(+), 1 deletion(-)

git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/11/37111/1
diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index 3c707d1..7b9503a 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -7493,7 +7493,11 @@
execute( TC_gsup_mt_sms_rp_mr() );
execute( TC_gsup_mo_mt_sms_rp_mr() );
execute( TC_gsup_mt_multi_part_sms() );
- execute( TC_gsup_mt_sms_lu_delay() );
+ if (f_osmo_repo_is("nightly")) {
+ /* timer X36 is not supported by osmo-msc <= 1.11.1
+ * Related: osmo-msc.git Ic519cab55d65e47b2636124427dab1a1d80fab78 */
+ execute( TC_gsup_mt_sms_lu_delay() );
+ }

execute( TC_lu_and_mo_ussd_single_request() );
execute( TC_lu_and_mt_ussd_notification() );

To view, visit change 37111. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0b07076a054e30c5a9023de18f2c70f15c97f8cc
Gerrit-Change-Number: 37111
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-MessageType: newchange