Attention is currently required from: fixeria, laforge, pespin.

4 comments:

File src/osmo-bsc/system_information.c:
- Patch Set #2, Line 1428:
```
unsigned int save_cur_bit;
	struct gsm_subscriber_connection *c;
```
  both vars can be moved to the scope of use (for-loop)
  I always want to separate variables from code. Even if it has no performance/memory gain, I want to have variables on top and code below.
- Patch Set #2, Line 1447: 32
  Thanks for adding the comment. I still see a possible problem though. […]
  SI 10 uses channel index with 5 bit. This means that it can address only the first 32 neighbor channels that are defined by SI5*. It does not make sense that there are more than 32 neighbor cells, because they cannot be reported by measurement report, which uses 5 bits as index too.
- Patch Set #2, Line 1499: /* Do spare padding. We cannot do it earlier, because encoding might corrupt it if differenctial cell info
  So if you mean "differential", then please use the correct spelling.
  Done
File src/osmo-bsc/system_information.c:
- Patch Set #4, Line 1456: llist_for_each_entry(c, &conn->vgcs_chan.call->vgcs_call.chan_list, vgcs_chan.list) {
  "struct gsm_bts *c_bts;" can be moved here (loop scope).
  I always want to separate variables from code. Even if it has no performance/memory gain, I want to have variables on top and code below.

To view, visit change 34626. To unsubscribe, or for help writing mail filters, visit settings.