Attention is currently required from: fixeria, pespin.

Patch set 1:Code-Review -1

View Change

1 comment:

• Patchset:

  • Patch Set #1:

    Quick test for whoever. Under bash: […]

    Hmm, the problem is that debian's "dash" behaves differently.

    
    ```
    $ dash
    $ echo -e "\033[1;32mBYE\033[1;0m"
    -e BYE
    ```

    ```
    $ ls -l /bin/sh
    lrwxrwxrwx 1 root root 4 Mar 31 2024 /bin/sh -> dash
    ```

    In this case I would either recommend using POSIX shell compatible syntax instead with printf:

    ```
    printf "\033[1;32m%s\033[1;0m\n" "BYE"
    ```

    
    This one works as expected with dash, bash and zsh.

    Or changing `#!/bin/sh` to `#!/bin/bash`, in addition with the changes you already have in this patch.

To view, visit change 41547. To unsubscribe, or for help writing mail filters, visit settings.