Attention is currently required from: Hoernchen, laforge.
Patch set 1:Code-Review +1
4 comments:
Patchset:
I have tried it out. It works fine. Except that I now also get a non working --decode-for-df flag on the regular read_record(s)_decoded commands.
File pySim/ts_102_221.py:
Patch Set #1, Line 755: arr_seq = self.__get_do_sequence(kwargs.get('encode_for_df', False))
I assume this is to maintain API consistency and possibly a future "update_arr_record" command.
Patch Set #1, Line 760: read_arr_argparser = copy.copy(LinFixedEF.ShellCommands.read_rec_dec_parser)
When I try this out and do a "read_record_decoded --help", I also get the --decode-for-df parameter in the helpscreen. I think you have to use copy.deepcopy here.
(This patch only adds the encode/decode variants to the read_arr_record(s) commands. Maye the feature would also be useful with the regular read_record_decoded commands as well?)
Patch Set #1, Line 761: read_arr_argparser.add_argument('--decode-for-df', action='store_true')
Maybe adding a help text like: help='decode EF.ARR record for DF' ?
To view, visit change 43254. To unsubscribe, or for help writing mail filters, visit settings.