Attention is currently required from: pespin.

Patch set 8:Code-Review -1

View Change

1 comment:

• File src/host/layer23/src/modem/grr.c:

  • Patch Set #6, Line 210: FN=%u BCCH message (type=0x%02x)

    what do you mean? I believe it's fixed now.

    The problem is that you changed the format string, but didn't change the argument ordering. Now the `type=0x%02x` gets the value of `fn` and `fn=%u` gets the value of `si_type` - this is wrong. You can fix it as follows:

    ```
    	LOGP(DRR, LOGL_INFO, "BCCH message (type=0x%02x, fn=%u): %s\n",
    -	     fn, si_type, gsm48_rr_msg_name(si_type));
    +	     si_type, fn, gsm48_rr_msg_name(si_type));
    ```

To view, visit change 34133. To unsubscribe, or for help writing mail filters, visit settings.