Attention is currently required from: roox, laforge, roh.
Patch set 1:Code-Review +1
View Change
1 comment:
Patchset:
Patch Set #1:
Looks good. The minor details I'm not sure about :
- using 0xd0 protocol vs another subclass for the GPSDO interface. I figured protocols could be used for different frame format in the future or something. Doesn't matter much.
- requests numbers starting at 0x10, they're now at intf level so technically they don't really need to.
Neither of which probably matter, just what I noticed while reading.
To view, visit change 27017. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: Icd6555a14896c38626fb147b78af44ff719f2254
Gerrit-Change-Number: 27017
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge@osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: roh <jsteiger@sysmocom.de>
Gerrit-Reviewer: roox <mardnh@gmx.de>
Gerrit-Reviewer: tnt <tnt@246tNt.com>
Gerrit-Attention: roox <mardnh@gmx.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: roh <jsteiger@sysmocom.de>
Gerrit-Comment-Date: Mon, 31 Jan 2022 11:37:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment