Attention is currently required from: dexter, laforge, neels.

View Change

1 comment:

• File src/codec/ecu_fr.c:

  • Patch Set #5, Line 315: struct fr_ecu_state *fr = (struct fr_ecu_state *) st;

    Thanks. I have added this now as suggested, but I still do not understand where the advantage is. […]

    It removes the need of having one struct being the first field of the other one, plus avoid having problems in the future if somebody decides to add other fields.

    This way the compiler is responsible for calculating the address instead of tricking it through explicit casting.

To view, visit change 35212. To unsubscribe, or for help writing mail filters, visit settings.