Attention is currently required from: csaba.sipos.
1 comment:
File src/osmo-bsc/bts_nokia_site.c:
if (link->sapi == SAPI_RSL) {
ts->lapd->profile.n200 = 20;
ts->lapd->profile.t200_sec = 1;
ts->lapd->profile.t200_usec = 0;
lapd_sap_start(ts->lapd, link->tei,
link->sapi);
} else {
ts->lapd->profile.t200_sec = 1;
ts->lapd->profile.t200_usec = 0;
lapd_sap_start(ts->lapd, link->tei,
link->sapi);
I think you can reduce code duplication here a bit:
```suggestion
/* XXX: a brief comment here is welcome! */
if (link->sapi == SAPI_RSL)
ts->lapd->profile.n200 = 20;
ts->lapd->profile.t200_sec = 1;
ts->lapd->profile.t200_usec = 0;
lapd_sap_start(ts->lapd, link->tei,
link->sapi);
```
To view, visit change 42289. To unsubscribe, or for help writing mail filters, visit settings.