Attention is currently required from: neels.
1 comment:
Commit Message:
Decided for now that it's not worth the extra effort to make this more
restrictive
I would beg to differ. It is opening up the chance for all kinds of bugs if 'random' packets are permitted here. IMHO we should be rather restrictive in what we permit. I even don't like the general idea of having to accept packets from "anywhere". But from your commit log it seems like this is mandatory to achieve a working solution. In that case we should further constrain what is an accepted packet (and in which state we do so), as you describe below.
Doesn't have to be neccessarily in this patch, but IMHO should be following up immediately.
To view, visit change 35205. To unsubscribe, or for help writing mail filters, visit settings.