Attention is currently required from: laforge, pespin, fixeria.
Patch set 1:Code-Review +1
View Change
2 comments:
File src/osmo_ss7.c:
Patch Set #1, Line 1951: rc = 0;
Yes, this is fine, we just clear any error code (like -EBADF) which may trigger stuff in the callbac […]
Ack
Patch Set #1, Line 1954: if (rc < 0) {
I prefer keeping the 2 scenarios separate, even if we end up doing the same right now. […]
Ack
To view, visit change 34089. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: If3d78b636e8e224aa9c8597d0b242e29d3e3c84e
Gerrit-Change-Number: 34089
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-CC: laforge <laforge@osmocom.org>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Mon, 21 Aug 2023 10:13:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith@sysmocom.de>
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Gerrit-MessageType: comment