Attention is currently required from: laforge, pespin.

Patch set 4:Code-Review +1

View Change

5 comments:

• File src/core/tun.c:

  • Patch Set #4, Line 73: *NULL

    missing space

  • Patch Set #4, Line 238: LOGTUN(tundev, LOGL_ERROR, "Cannot obtain netns file descriptor: %s (%d)\n",

    log netns_name here?

  • Patch Set #4, Line 245: if (tundev->netns_name) {

    same condition, why is this not part of the above if-block?

  • Patch Set #4, Line 405: whien

    when

  • Patch Set #4, Line 421: osmo_tundev_encaps

    probably just my personal point of view, but let's see if others agree: I find it a bit odd to call […]

    agreed

To view, visit change 31025. To unsubscribe, or for help writing mail filters, visit settings.