laforge submitted this change.

View Change


Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified
trau_pcu_ericsson: do not set unused D bits to 1

The er_gprs_trau_frame_encode already pre set all non T0 bits in the
TRAU frame to 1, there is no need to set unused bits explicitly.

Related: OS#6015
Change-Id: I003632a08cc80bc195b306bef5f907351b6fe94e
---
M src/trau/trau_pcu_ericsson.c
1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/src/trau/trau_pcu_ericsson.c b/src/trau/trau_pcu_ericsson.c
index 8f2e2a2..ac48520 100644
--- a/src/trau/trau_pcu_ericsson.c
+++ b/src/trau/trau_pcu_ericsson.c
@@ -1067,9 +1067,7 @@
trau_bits[73] = 0;
trau_bits[74] = calc_parity(trau_bits + 65, 8);

- /* Set unused D-Bits to 1 */
- memset(trau_bits + 76, 1, 1280 - 76 - 16);
-
+ /* unused D-bits are initialized in er_gprs_trau_frame_encode */
/* D-Bits */
rc = put_trau_uint32(trau_bits, 1280, T_bits_64, sizeof(T_bits_64), ind->pseq, 170, 22);
if (rc < 0)

To view, visit change 32543. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I003632a08cc80bc195b306bef5f907351b6fe94e
Gerrit-Change-Number: 32543
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith@rhizomatica.org>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-MessageType: merged