pespin would like laforge to review this change.

View Change

om2000: Fix memory leak in OM2000 message handling

Change-Id: I7a94320f3b3af65003df67c11fe7221dfc7d7d62
---
M src/osmo-bsc/abis_om2000.c
1 file changed, 3 insertions(+), 2 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/72/26872/1
diff --git a/src/osmo-bsc/abis_om2000.c b/src/osmo-bsc/abis_om2000.c
index 8ee6371..16320fc 100644
--- a/src/osmo-bsc/abis_om2000.c
+++ b/src/osmo-bsc/abis_om2000.c
@@ -3042,17 +3042,18 @@
if (!mo) {
LOGP(DNM, LOGL_ERROR, "Couldn't resolve MO for OM2K msg "
"%s: %s\n", get_value_string(om2k_msgcode_vals, msg_type), msgb_hexdump(msg));
- return 0;
+ goto no_mo;
}
if (!mo->fsm) {
LOGP(DNM, LOGL_ERROR, "MO object should not generate any message. fsm == NULL "
"%s: %s\n", get_value_string(om2k_msgcode_vals, msg_type), msgb_hexdump(msg));
- return 0;
+ goto no_mo;
}

/* Dispatch message to that MO */
om2k_mo_fsm_recvmsg(bts, mo, &odm);

+no_mo:
msgb_free(msg);
return rc;
}

To view, visit change 26872. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-bsc
Gerrit-Branch: pespin/1-8-0
Gerrit-Change-Id: I7a94320f3b3af65003df67c11fe7221dfc7d7d62
Gerrit-Change-Number: 26872
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu>
Gerrit-MessageType: newchange