Attention is currently required from: dexter.

View Change

5 comments:

• File contrib/csv-to-pgsql.py:

  • Patch Set #4, Line 16: # cmd2 >= 2.3.0 has deprecated the bg/fg in favor of Bg/Fg :(

    Other than `YELLOW`, `cmd2` API is not used in this script. I would avoid importing it just because you want a color in logging. I believe you can just use an ASCII color code?

  • Patch Set #4, Line 225: log.info("CSV file: %s" % opts.csv)

    BTW, for logging API it's recommended to use lazy format-sting evaluation:

    ```
    log.info("CSV file: %s", opts.csv)
    ```

  • Patch Set #4, Line 227: if not csv_file:

    Does `open()` return `None` at all? It raises an exception on error.

• File pySim/card_key_provider.py:

  • Patch Set #4, Line 242: break;

    cosmetic: semicolon is not needed here

• File setup.py:

  • Patch Set #4, Line 37: psycopg2-binary

    Not blocking here, but do we really want this as a required dependency? This list is already quite long, giving headaches to those trying to package pySim...

To view, visit change 41508. To unsubscribe, or for help writing mail filters, visit settings.