Attention is currently required from: daniel, fixeria, laforge, pespin.

View Change

5 comments:

• File _testenv/data/podman/Dockerfile:

  • Patch Set #2, Line 94: python3 setup.py clean build install

    we should finally start using `pip install`, since running `setup. […]

    Done

• File _testenv/data/podman/seccomp_profile.json:

  • Patch Set #2, Line 20: "subArchitectures": [

    is this file a modified file from some other source? If yes, then I would appreciate if we can chec […]

    Done

• File _testenv/data/scripts/rename_junit_xml_classname.sh:

  • Patch Set #2, Line 1: #!/bin/sh -e

    maybe 1-2 line description on top of the file what it does? Yes, rename something - but why and how […]

    Done

• File _testenv/testenv.py:

  • Patch Set #2, Line 2: import logging

    please add some kind of copyright statement, license header and summary description to all of the py […]

    Done

• File _testenv/testenv/osmo_dev.py:

  • Patch Set #2, Line 49: logging.error(testenv.src_dir)

    I see a some line wrapping that looks like its way before we hit the 120 character max line length o […]

    Done

To view, visit change 37694. To unsubscribe, or for help writing mail filters, visit settings.