Attention is currently required from: daniel.
3 comments:
Commit Message:
Patch Set #1, Line 16: mean time. To avoid that set the parent of any msgb in the tx queue to the
time is indeed mean sometimes.
Patchset:
All the talloc parent in here looks already quite complex and I have the feeling it's becoming even more complex here. I think all this deserves a bit more of explanation/documentation since I think I'm not gasping it completely.
IIUC we used to enqueue messages to be written to the socket in an internal queue of iofd, but those messages where actually not owned (talloc parent) by the iofd, but by some other random context outside of it. This looks wrong to me. messages enqueued in an iofd should always be owned by iofd.
I think you are going into this direction (iofd owning it) but the solution passing lots of extra ctx doesn't look good to me at first sight. I'd welcome further explanation on why all those ctx pointers are needed.
File src/core/osmo_io.c:
non-related ws
To view, visit change 34144. To unsubscribe, or for help writing mail filters, visit settings.