Attention is currently required from: laforge.
1 comment:
Patchset:
it will bite us in the butt if we ever want to change anything about this function, and the strange assumption no longer holds true.
I am afraid I don't follow. Suppose we decide that no sane user application is going to set only C4 (`fr->c_bits[3]`) while leaving the other 4 C-bits in that group uninitialized/garbage, and we change the function to always use all of `fr->c_bits[]`, like we already do for OSMO_TRAU8_DATA. (In fact, I have a patch that does just that - would you like me to submit it as a merge candidate?) In that case, the local function for computing odd parity *still* goes away just like with the present patch - so I don't see where the "bite in the butt" would happen.
But I have no particular attachment to the present patch. I produced it because it seemed like a sensible code simplification/clean-up, but it does not change any functionality or behavior, so if you (and/or other senior maintainers) don't like it, then fine, no big deal.
To view, visit change 39669. To unsubscribe, or for help writing mail filters, visit settings.