laforge submitted this change.

View Change

Approvals: fixeria: Looks good to me, but someone else must approve Hoernchen: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve
comma_delimited_to_vector() optimization CID#465430

(I am not sure about this, just doing as coverity says.)

Change-Id: I30e57c6a9df39552bc4f8c18d27bc421f5c60f49
---
M CommonLibs/Utils.cpp
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CommonLibs/Utils.cpp b/CommonLibs/Utils.cpp
index 3ab598d..6703531 100644
--- a/CommonLibs/Utils.cpp
+++ b/CommonLibs/Utils.cpp
@@ -28,7 +28,7 @@
{
std::string substr;
getline(ss, substr, ',');
- result.push_back(substr);
+ result.push_back(std::move(substr));
}
return result;
}

To view, visit change 39359. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I30e57c6a9df39552bc4f8c18d27bc421f5c60f49
Gerrit-Change-Number: 39359
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>