Attention is currently required from: neels, laforge, fixeria, msuraev.

View Change

7 comments:

• File src/sccp_scoc.c:

  • Patch Set #15, Line 642: /* optional: importance */

    why is this line removed here? this is non related.

  • Patch Set #15, Line 600: if (

    in whihc situation would we have a zero-length opt_data_cache?

    Ack

  • Patch Set #15, Line 606: } else

    remove curly braces in the if.

  • Patch Set #15, Line 630: if (xua_drop_data_check(prim, SCCP_MAX_DATA, "cache overrun"))

    ...check_drop(), otherwise it's not clear what you are checking and it's confusing since you actually check for drop and return the opposite to keep it.
    Actually, since you call this function _keep(), it would make sense to reverse the loginc on the xua_drop_data_check() function...
    I would even drop the function completely tbh.

  • Patch Set #15, Line 635: LOGP(DLSCCP, LOGL_ERROR, "replacing unsent %u bytes of optional data cache with %s optional data\n",

    NOTICE

  • Patch Set #15, Line 639: msgb_alloc(SCCP_MAX_DATA, "SCCP optional data cache for CR/CC/RLSD");

    If we ever should run into memory leaks, it would be better to use msgb_alloc_c(conn) to attach this […]

    Ack

  • Patch Set #15, Line 784: xua_msg_add_sccp_addr(xua, SUA_IEI_DEST_ADDR, &conn->calling_addr);

    why is this line removed here? this is non related.

To view, visit change 29084. To unsubscribe, or for help writing mail filters, visit settings.