Attention is currently required from: arehbein, laforge, fixeria.
1 comment:
File src/common/pcu_sock.c:
Patch Set #2, Line 1102: osmo_fd_write_disable(&state->upqueue.bfd);
I have looked at some of our projects and seen similar code (code that disables the fd before calling write or transmitting data (probably also ultimately calling write) in osmo-trx, osmo-bts and libosmo-abis code.
That should happen only when the wqueue becomes empty, please have a look at the code and if it's not the case share a detailed example.
I see that this can be done in the previous because it's inside a while(!llist_empty()) loop, but then it makes no sense to call it on every loop iteration. In this new code here, you cannot do that.
Probably isn't noticeable because sooner or later, the enable happens, anyways.
Yes, next time a packet is enqueued. That doesn't mean it's correct though.
I submitted https://gerrit.osmocom.org/c/osmo-bts/+/31924 to clean up this function, this may amke it easier for you to understand, feel free to rebase your work on top of it.
To view, visit change 31533. To unsubscribe, or for help writing mail filters, visit settings.