Attention is currently required from: pespin.

Patch set 2:Code-Review +1

View Change

1 comment:

• File include/osmocom/mgcp_client/mgcp_client_pool.h:

  • Patch Set #2, Line 17: mgcp_client_pool_member_get

    Not so obvious from the function name what this does. get what? also I wouldn't have guessed that it increases a refcounter without looking at the implementation. I know the return type explains what one will get, but still it seems a bit weird to me. I guess it fits the existing mgcp_client_pool_get. Not sure how to improve this though, and it shouldn't block this patch.

To view, visit change 29750. To unsubscribe, or for help writing mail filters, visit settings.