osmith submitted this change.

View Change

Approvals: pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified
Makefile: fix doc/vty race condition

It is possible that doxygen is unable to create the "doc/vty" directory,
as we have seen in jenkins. Create it before running doxygen as it is
done for other doc dirs above, e.g.:

rm -rf $(top_builddir)/doc/isdn; mkdir -p $(top_builddir)/doc/isdn

Note that the doc/vty dir is expected to exist already inside the source
tree, as it contains versioned failes. As I understand it, the error
happens when building out-of-tree.

Fix for:
error: tag OUTPUT_DIRECTORY: Output directory 'doc/vty' does not exist and cannot be created
Doxygen version used: 1.9.4
Exiting...
touch "doc/libosmovty.tag.prep"
make[2]: [Makefile:1357: doc/libosmovty.tag.prep] Error 1 (ignored)
touch: cannot touch 'doc/libosmovty.tag.prep': No such file or directory

Related: https://gerrit.osmocom.org/c/libosmocore/+/39827/1#message-02393b0dc4323a19eb2fd2a19422f50439b81953
Change-Id: If9029059ac60060bdb14f5629f50836166e3afd7
---
M Makefile.am
1 file changed, 1 insertion(+), 0 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index 8a8f963..7adb00b 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -115,6 +115,7 @@
$(top_srcdir)/src/vty/*.c
rm -rf $(top_builddir)/doc/vty/html $(top_builddir)/doc/vty/latex
rm -rf $(top_builddir)/doc/libosmovty.map
+ mkdir -p $(top_builddir)/doc/vty
-$(DOXYGEN) $(top_builddir)/Doxyfile.vty
touch "$@"


To view, visit change 39839. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If9029059ac60060bdb14f5629f50836166e3afd7
Gerrit-Change-Number: 39839
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>