Attention is currently required from: fixeria, laforge.

View Change

4 comments:

• File contrib/csv-to-pgsql.py:

  • Patch Set #1, Line 38: log = PySimLogger.get(__name__)

    Indeed, `log` should be accessible globally. […]

    I have re-tested this. There seems to be no problem when removing the line. I think I was just irritated. Maybe the problems I had when I was writing the original code were caused by something else that resolved itself later.

• File contrib/csv-to-pgsql.py:

  • Patch Set #2, Line 15: log = PySimLogger.get("csv-to-pqsql")

    you can generalize this with […]

    Thanks for the hint. This works fine. I have updated it now in the other code locations as well.

• File contrib/es2p_server.py:

  • Patch Set #2, Line 35: logger = logging.getLogger("es2p_server")

    you can generalize this with […]

    Done

• File pySim/card_key_provider.py:

  • Patch Set #1, Line 41: PySimLogger.get

    I was wrong about inheriting configuration of the parent loggers then. […]

    ACK, then we work on this later. I think it would be great if we could make it work this way. Things would be a lot simpler then.

To view, visit change 41890. To unsubscribe, or for help writing mail filters, visit settings.