Attention is currently required from: laforge, pespin.

View Change

8 comments:

• File src/core/osmo_io.c:

  • Patch Set #3, Line 165: hdr->msg_max = (g_io_backend == OSMO_IO_BACKEND_IO_URING) ? g_io_uring_iov : 1;

    this info should be obtained from osmo_io_fd struct.

    Done

  • Patch Set #3, Line 406: struct msgb *msg = msghdr->msg[0];

    I see now, because this commit is actually not yet adding support for >1 msgb per msghdr, it's only […]

    Done

• File src/core/osmo_io.c:

  • Patch Set #5, Line 727: iofd->io_buffers = (g_io_backend == OSMO_IO_BACKEND_IO_URING) ? g_io_uring_iov : 1;

    sounds like we want to have this per-backend logic as part of the per-backend ops, and not here.

    It is set by an API function now.

• File src/core/osmo_io.c:

  • Patch Set #6, Line 747: * If your osmo_io_fd is in OSMO_IO_FD_MODE_READ_WRITE mode, this API function can be used to tell the

    Please add proper doxygen documentation of params here.

    Done

  • Patch Set #6, Line 748: * osmo_io code how many buffers should be read or written with a single read or write operation.

    "read or write". Extra space.

    Done

  • Patch Set #6, Line 751: int osmo_iofd_set_io_buffers(struct osmo_io_fd *iofd, int buffers)

    unsigned int buffers? […]

    Done

• File src/core/osmo_io_internal.h:

  • Patch Set #6, Line 143: int io_len;

    this can also be a unsigned int. And even actually a uint8_t.

    Done

• File src/core/osmo_io_uring.c:

  • Patch Set #3, Line 110: g_io_uring_iov = atoi(env);

    afaict this is not some information which is needed really early in the startup of the program, befo […]

    It is configured in an API function now.

To view, visit change 40491. To unsubscribe, or for help writing mail filters, visit settings.