osmith has uploaded this change for review.

View Change

src/rspro_client_fsm: fix osmo_stream_cli_destroy

Run osmo_stream_cli_close() before osmo_stream_cli_destroy(), as
otherwise _destroy() fails with:

  Assert failed stream_cli_close(cli) == false ../../src_copy/libosmo-netif/src/stream_cli.c:1023

Reproducer in osmo-ttcn3-hacks:
  ./testenv.py run remsim -c client -t RemsimClient_Tests.TC_bank_disconnect

Change-Id: I0da0b4354532b4e13d0c4bf4b132ec774f24497f
---
M src/rspro_client_fsm.c
1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/20/39920/1

diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c
index d847f3b..01cf3fe 100644
--- a/src/rspro_client_fsm.c
+++ b/src/rspro_client_fsm.c
@@ -534,6 +534,7 @@
 	case SRVC_E_DISCONNECT:
 		if (srvc->conn) {
 			LOGPFSML(fi, LOGL_INFO, "Destroying existing connection to server\n");
+			osmo_stream_cli_close(srvc->conn);
 			osmo_stream_cli_destroy(srvc->conn);
 			srvc->conn = NULL;
 		}

To view, visit change 39920. To unsubscribe, or for help writing mail filters, visit settings.