Attention is currently required from: laforge, neels.

Patch set 5:Code-Review -2

View Change

3 comments:

• Commit Message:

  • Patch Set #2, Line 13:

    The underlying issue, I presume, is that either the data needs
    validation before decode_record_bin(), or decode_record_bin() needs
    well-defined error handling.
    

    We are here reading an example template from GSMA and get an exception.

    
    But with this patch we're silently dropping `EF.SMPP` as if it was not present; we're not even logging an error. And we're not catching other possible kinds of exceptions here, like `ConstructError`, so this does not solve the problem fundamentally.

• Commit Message:

  • Patch Set #5, Line 55:

      File "/application/venv/lib/python3.13/site-packages/osmocom/construct.py", line 268, in _decode
        if r[-1] == 'f':
           ~^^^^
      File "/application/venv/lib/python3.13/site-packages/osmocom/utils.py", line 50, in __getitem__
        return hexstr(super().__getitem__(val))
                      ~~~~~~~~~~~~~~~~~~~^^^^^
    In
    

    Looking at the backtrace you provided, the `IndexError` comes from our
    pyosmocom code, not from construct. I checked the related code path and it looks like the problem has been fixed in https://gerrit.osmocom.org/c/python/pyosmocom/+/41731? I think we can abandon this patch.

• File pySim/esim/saip/personalization.py:

  • Patch Set #5, Line 618:

                f_smsp = pe.files.get('ef-smsp', None)
                if f_smsp is None:
      
    

    We may still want to merge this part though.

To view, visit change 41920. To unsubscribe, or for help writing mail filters, visit settings.