View Change

2 comments:

• File src/osmo-hnbgw/hnbgw_cn.c:

  • Patch Set #7, Line 362: switch (((uint8_t *)msgb_l2(oph->msg))[1]) {

    why such a hack here and peek into the raw msgb without the use of the decoder? Why not simply decode the message first (at least the first level of decode into a RANAP_RANAP_PDU_t) and then check the procedure code?

    If you want to go for this low-level-hackish approach, you need to be able to prove that there is no flexibility within the encoding rules that would permit a message to have e.g. a multi-byte RAB assignment type. I know that BER leaves a lot of flexibility to the sender, and you can format any integer any number of bytes wide, so the same value has any number of different encodings. APER is probably stricter, but have you studied the encoding rules?

• File src/osmo-hnbgw/hnbgw_rua.c:

  • Patch Set #7, Line 273: case RANAP_ProcedureCode_id_RAB_Assignment:

    likewise the same here.

To view, visit change 26795. To unsubscribe, or for help writing mail filters, visit settings.