Attention is currently required from: fixeria, dexter.

View Change

1 comment:

• File src/pcu_l1_if.cpp:

  • Patch Set #1, Line 1027: e1_ccu_conn_pars = talloc_zero(tall_pcu_ctx, struct e1_ccu_conn_pars);

    I don't think that this is necessary. […]

    Yes, it my be the only place, but still it makes it more difficult for people trying to understand the code to find out where the struct e1_ccu_conn_pars is allocated.
    If you have a e1_ccu_conn_pars_alloc() it became obvious with a simple grep.

To view, visit change 31174. To unsubscribe, or for help writing mail filters, visit settings.