Attention is currently required from: fixeria, laforge, pespin.

View Change

1 comment:

• File include/osmocom/hlr/hlr_sms.h:

  • Patch Set #2, Line 17: void smsc_del(struct hlr_smsc *smsc);

    Regarding "adding object to llist during alloc", I think it makes sense to do so and it's useful/sim […]

    @laforge says that alloc+del is inconsistent, instead it should be either alloc+free or add+del - and I agree. In the present case of HLR configs for EUSE/USSD and SMSC entities and routing, it looks like I need to do the following sequence:

    1) mark the present patch as WIP;
    2) prepare a separate patch changing the existing EUSE/USSD code to the agreed-upon convention, and get that patch through review to merge;
    3) revisit the present patch and make it the same as the newly fixed EUSE/USSD.

    What I need now is an agreement from @laforge and @pespin on which convention I should use in the present cases of EUSE/USSD and SMSC: alloc+free or add+del?

To view, visit change 34448. To unsubscribe, or for help writing mail filters, visit settings.