Attention is currently required from: neels.

View Change

2 comments:

• Patchset:

  • Patch Set #2:

    This extra level of indirection having to specify a map makes stuff too complex for no reason imho.

    In the end, the ttcn3 user of the rate_ctr knows whether it needs to use a string or a index to access the counter, so it can use whatever is needed directly.

    I think this should be implemented by:

    • Have new generic APIs of the index-based existing ones, where instead of an index a string is passed.
    • Change the existing index-based API implementations to use the ones above by doing str2int(index).

    Then, the user can use those APIs directly, eg. passing a string of a Cell Id or whatever may be needed.

• File library/Osmocom_CTRL_Functions.ttcn:

  • Patch Set #2, Line 161: * cell ID instad, pass in a mapping of index to cell id, to use the name given by rate_ctr_group_set_name()

    instead

To view, visit change 37882. To unsubscribe, or for help writing mail filters, visit settings.