Attention is currently required from: daniel, laforge, pespin.
5 comments:
File include/osmocom/mgcp/mgcp_protocol.h:
Patch Set #4, Line 7: #define MGCP_PARSE_HDR_PARS_OSMUX_CID_WILDCARD (-1)
Yeah in general, but in this case it's not a closed-set of options, but 2 specific options within in […]
i disagree with that position. i feel that lists of separate #defines for any number of related ints, nevermind the used range, is a hack from times where our early ancestors didn't know about curly braces yet and had barely discovered fire ... enums are an actual part of the C language proper that can be used as return type or argument type to clarify things, #defines are a preprocessor shim, much like a flea circus...
i will not block this, but i challenge you to admit that mentioning the int range is just a lame excuse.
File src/libosmo-mgcp/mgcp_msg.c:
Patch Set #4, Line 210: goto mgcp_header_done;
I prefer handling it below as it is now, and as it used to be too. […]
It is a label with a single caller, that simply does "return 0": there is no logic to preserve.
It is the textbook example of meaningless bloat.
it is a non-functional cosmetic issue, so i am dialing back a bit, but i find this beyond weird.
Patch Set #4, Line 218: return 0;
To me this makes it easier to understand that you can finish properly based on whether you arrived t […]
empty words.
(resolving this one so we don't say the same things twice)
File src/libosmo-mgcp/mgcp_protocol.c:
Patch Set #4, Line 873: hpars->remote_osmux_cid = MGCP_PARSE_HDR_PARS_OSMUX_CID_UNSET;
Yeah well a lot of stuff is quite fucked up, but we cannot fix it all in one commit. […]
This patch does exactly the right thing: it introduces proper layering boundaries. So I would like the new code to observe the boundaries that it introduces. This is not about a fix of earlier code.
Patch Set #4, Line 899: endp->x_osmo_ign |= hpars->x_osmo_ign;
Yes |= because it's in the endp, it's shared by several conns. […]
ok!
To view, visit change 39224. To unsubscribe, or for help writing mail filters, visit settings.