Attention is currently required from: neels, pespin.

Patch set 2:Code-Review +1

View Change

1 comment:

• Commit Message:

  • Patch Set #1, Line 17: entire SCCP conn id number space before exiting in failure.

    In some programs we have sanity counters to limit iterations to find an unused ID, I think like 1000 […]

    If you want a faster lookup, I think the only way to do this is to move away from a per-instance linked list of SCCP connections to some kind of hash table or tree. This way it is cheaper to verify if a given ID is used or not. Only iterate a few tree nodes or the usually very short list of entries of a hash table bucket.

    But I do think that is a separate topic, and the kind of deployments we're expecting will not see a situatoin nowhere near SCCP ID exhaustion.

To view, visit change 32320. To unsubscribe, or for help writing mail filters, visit settings.