Attention is currently required from: laforge.

View Change

1 comment:

• File src/rspro_client_fsm.c:

  • Patch Set #1, Line 142:

    static int srvc_ipa_segmentation_cb2(struct osmo_stream_cli *cli, struct msgb *msg)
    {
    	return osmo_ipa_segmentation_cb(msg);
    }
    
    

    it's not really elegant that this API improvement now requires us to sprkinkle boilerplate code like […]

    @laforge@gnumonks.org While it involves a bit more code I think it's totally fine.
    If you don't like the proposed approach, the alternative approach is to un-deprecate segmentation_cb (allowing any of segmentation_cb and segmentation_cb2 to be used) and then dropping this patchset (keep using segmentation_cb here).

    Let me know which one you prefer and I'll do so.

To view, visit change 39385. To unsubscribe, or for help writing mail filters, visit settings.