laforge submitted this change.

View Change



1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved dexter: Looks good to me, but someone else must approve
es9p_client: Fix type conversion in installation result notification

The asn.1 encoder expects bytes-like objects, we cannot simply pass
hex-strings to it without conversion

Change-Id: I83ad047e043dc6b3462b188ce6dd0b2cc0e52e87
---
M contrib/es9p_client.py
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/contrib/es9p_client.py b/contrib/es9p_client.py
index e9a71fc..c1455dc 100755
--- a/contrib/es9p_client.py
+++ b/contrib/es9p_client.py
@@ -128,12 +128,12 @@

if self.opts.operation == 'download':
pird = {
- 'transactionId': self.opts.transaction_id,
+ 'transactionId': h2b(self.opts.transaction_id),
'notificationMetadata': ntf_metadata,
'smdpOid': self.opts.smdpp_oid,
'finalResult': ('successResult', {
- 'aid': self.opts.isdp_aid,
- 'simaResponse': self.opts.sima_response,
+ 'aid': h2b(self.opts.isdp_aid),
+ 'simaResponse': h2b(self.opts.sima_response),
}),
}
pird_bin = rsp.asn1.encode('ProfileInstallationResultData', pird)

To view, visit change 41973. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I83ad047e043dc6b3462b188ce6dd0b2cc0e52e87
Gerrit-Change-Number: 41973
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge@osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>