Attention is currently required from: dexter, neels, osmith.
1 comment:
File pySim/esim/saip/personalization.py:
Patch Set #3, Line 651: if rec_len
I don't think "if rec_len" is the right predicate here. IMHO, it will always be true. I guess you wanted to check "if len(f_smsp.body) > rec_len" ?
Even in that case, I'm not entirely sure if it's needed. I would expect that f_smsp.body[len(f_smsp.body):] would always be an empty byte-string and hence can be safely appended? Best to try it in form of a test case.
To view, visit change 43983. To unsubscribe, or for help writing mail filters, visit settings.