Attention is currently required from: pespin.
10 comments:
Patchset:
@pespin: I like to keep most of the #ifdef / #endif out of the code. The header file already takes care if the feature isn't enabled.
Why do you want to have the #ifdef everywhere in the code?
The header file transform it into no-ops.
File examples/sccp_demo_user.c:
Patch Set #8, Line 30: void *talloc_asn1_ctx;
why is this added?
Because the library needs it.
File src/ipa.c:
Patch Set #8, Line 315: /* update TCAP Transaction Tracking (Rx) */
#ifdef WITH_TCAP_LOADSHARING
no, not needed.
Patch Set #8, Line 316: ss7_asp_tcap_rx_sccp(as, asp, opc, dpc, msg);
This function naming is a bit misleading since it's not even known whether there's TCAP in the msg.. […]
I want to keep the code changes to the other files minimal.
What would you suggest instead?
Patch Set #8, Line 360: case IPAC_PROTO_OSMO:
#ifdef WITH_TCAP_LOADSHARING
I could move it further upwards.
Patch Set #8, Line 368: if (hh_ext->proto == IPAC_PROTO_EXT_TCAP_ROUTING) {
(probably a switch case here will turn out cleaner together with the ifdef. […]
yes, I can use switch/case there.
File src/m3ua.c:
Patch Set #8, Line 50: #include "ss7_as_loadshare_tcap.h"
#ifdef WITH_TCAP_LOADSHARINGActually, I don't see this header being used in this file. […]
I prefer the style how it is currently. It reduces the usage of #ifdef in the common code.
Patch Set #8, Line 343: if (!xua)
This looks unrelated to this commit? Seems you want to add another commit describing this.
Ack.
File tests/tcap/tcap_transaction_tracking_test.c:
Patch Set #6, Line 19: typedef void (* tcap_trxn_track_test_func_t)(void);
space prohibited after that '*' (ctx:BxW)
fixed
Patch Set #6, Line 19: typedef void (* tcap_trxn_track_test_func_t)(void);
do not add new typedefs
Won't fix. I think it's fine here.
To view, visit change 41309. To unsubscribe, or for help writing mail filters, visit settings.