Attention is currently required from: pespin, fixeria, dexter.

View Change

2 comments:

• File src/bts.h:

  • Patch Set #16, Line 284: bool use_dt_confirm;

    what does "dt" mean?

• File src/pcu_l1_if.cpp:

  • Patch Set #5, Line 320: data[sizeof(tlli) + (PAGING_GROUP_LEN - 1 - i)]

    I think its still ok to keep it like it is. If we add items like this to pcuif_proto. […]

    i also dislike the pattern of unreadable encoding magic, especially in the middle of flow control and other decisions happening; that invites code dup and copy paste errors. Maybe adding packed structs for the other functions would not be a bad idea. (I'm not familiar with this code; if all of this is written in this way then I'd be fine to be outvoted, letting it be known that it objectively is ugly but we choose to live with it...)

    If it should be unreadable encoding magic, then can we have a separate function doing the encoding?

To view, visit change 31145. To unsubscribe, or for help writing mail filters, visit settings.