Attention is currently required from: pespin.
6 comments:
Commit Message:
Patch Set #1, Line 11: split the two cases.
can you pinpoint where did you "split the two cases"? I'm either not understand correctly or I didn' […]
Take a closer look at the () + args, as explained in the message...
File Transceiver52M/Complex.h:
Patch Set #1, Line 32: typedef Real value_type;
why this typedef?
To make the template work with the useless hand-rolled osmo-trx complex class that is not std::complex. Unfortunately osmo-trx has a Complex<T> typedefed as "complex" that is not really compatible with the plain old std::complex that is being used everywhere and which should be removed at some point, just like the weird "vector" class..
File Transceiver52M/ms/ms.h:
Patch Set #1, Line 58: namespace cvt_internal
please put some new line spacing between blocks inside here, otherwise it's hard to read.
Done
Patch Set #1, Line 66: template <typename DST_T, typename ST>
I don't think I'm following here. […]
() + args!
There still is only one three type template with proper type deduction that serves as the public interface, see usage pattern changes in the other files.
Patch Set #1, Line 72: template <typename ST> void convert_and_scale_i(float *dst, const float *src, unsigned int src_len, ST scale)
you have the template in a new line in functions above, but here in the same one.
Fixed by adjusting the clang-format file.
File Transceiver52M/ms/ms_upper.cpp:
Patch Set #1, Line 465: fesetround(FE_TOWARDZERO);
can you explain why are you dropping this?
Original hack related to rounding misadventures.
To view, visit change 30966. To unsubscribe, or for help writing mail filters, visit settings.