Attention is currently required from: daniel, fixeria, laforge, pespin.
View Change
2 comments:
File src/sccp_sclc.c:
Patch Set #2, Line 38: *
@laforge@gnumonks.org I removed those from here because theycare not really related to this file. […]
Done
File src/sccp_sclc.c:
Patch Set #3, Line 84: xua->mtp.sls = rand() & 0xf;
this looks like it could by chance become the same sls as in the seq_ctrl present case below. Is this desired? Maybe the intention was to do `& 0xf0`?
To view, visit change 39690. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I834e91c1ec337713b0e684cf4fd7de854150bef6
Gerrit-Change-Number: 39690
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann@sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: daniel <dwillmann@sysmocom.de>
Gerrit-Comment-Date: Fri, 07 Mar 2025 09:12:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge@osmocom.org>
Comment-In-Reply-To: pespin <pespin@sysmocom.de>