Attention is currently required from: osmith, fixeria.

View Change

1 comment:

• File src/osmo-bsc-nat/bsc_nat_fsm.c:

  • Patch Set #3, Line 78: *peer_addr_in = called_addr;

    Ack

    This doesn't look good to me, you are tricking the compiler here. Because at the caller, it will expect those 2 pointers to be not modified after the function, but they may through peer_addr_in.

To view, visit change 27260. To unsubscribe, or for help writing mail filters, visit settings.